Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be available with both eslint 7 and eslint 8 #20

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Be available with both eslint 7 and eslint 8 #20

merged 2 commits into from
Dec 10, 2021

Conversation

sanemat
Copy link
Contributor

@sanemat sanemat commented Dec 8, 2021

Why

Be available with eslint 8

What

  • relax dependencies for eslint 8
  • detect error on eslint 8

fixes #14

Other

for local confirmation:

rm package-lock.json
rm -rf ./node_modules
npm install eslint@^8.0.0
or
npm install eslint@^7.29.0

Matt (Murahashi Kenichi) added 2 commits December 8, 2021 13:32
chore(deps): relax dependencies for eslint8
c0b4ecd 
"@typescript-eslint/eslint-plugin": "^4.28.0 || ^5.0.0"
"@typescript-eslint/parser": "^4.28.0 || ^5.0.0"
"eslint-plugin-jest": "^24.3.6 || ^25.0.0"
"eslint-plugin-testing-library": "^4.6.0 || ^5.0.0"
chore(actions): check result with eslint8
4136b3b
@sanemat sanemat requested a review from kimromi December 8, 2021 04:45
kimromi
kimromi approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@kimromi kimromi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!!!!!

I confirmed #14 (comment)

package.json
"@typescript-eslint/eslint-plugin": "^4.28.0",
"@typescript-eslint/parser": "^4.28.0",
"@typescript-eslint/eslint-plugin": "^4.28.0 || ^5.0.0",
"@typescript-eslint/parser": "^4.28.0 || ^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 typescript-eslint/typescript-eslint#3737

package.json
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jest": "^24.3.6 || ^25.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 jest-community/eslint-plugin-jest#940

package.json
"eslint-plugin-jest-dom": "^3.9.0",
"eslint-plugin-next": "^0.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-react": "^7.24.0",
"eslint-plugin-react-hooks": "^4.2.0",
"eslint-plugin-testing-library": "^4.6.0"
"eslint-plugin-testing-library": "^4.6.0 || ^5.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 testing-library/eslint-plugin-testing-library#465

@kimromi kimromi merged commit 53a11bf into main Dec 10, 2021
@kimromi kimromi deleted the chore/use-eslint8 branch December 10, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimromi kimromi kimromi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's support eslint v8
2 participants
@sanemat @kimromi